[ROOTMaster] Updated root to tip of branch master by iarspider · Pull Request #8999 · cms-sw/cmsdist

iarspider · 2024-02-12T10:35:43Z

No description provided.

iarspider · 2024-02-12T10:35:51Z

please test

cmsbuild · 2024-02-12T10:36:05Z

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/rootmaster.

@smuzaffar, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2024-02-12T10:36:05Z

cms-bot internal usage

Dr15Jones · 2024-02-12T14:18:24Z

I also need this version of ROOT for tests I'm doing on RNTuple (as it has the newer interface).

cmsbuild · 2024-02-12T17:33:29Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37361/summary.html
COMMIT: 2e67a11
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8999/37361/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_ROOT6_X_2024-02-11-2300/src/FWCore/Framework/interface/LuminosityBlockForOutput.h:21,
                 from src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.h:8,
                 from src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/unique_ptr.h: In instantiation of 'std::__detail::__unique_ptr_t<_Tp> std::make_unique(_Args&& ...) [with _Tp = ROOT::Experimental::RNTupleWriter; _Args = {unique_ptr >, unique_ptr >}; __detail::__unique_ptr_t<_Tp> = __detail::__unique_ptr_t]':
src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.cc:26:45:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/unique_ptr.h:1065:30: error: 'ROOT::Experimental::RNTupleWriter::RNTupleWriter(std::unique_ptr, std::unique_ptr)' is private within this context
 1065 |     { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.h:14:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.31.01-a6b31fd47d9cb14388e9669f24a910f5/include/ROOT/RNTuple.hxx:462:4: note: declared private here
  462 |    RNTupleWriter(std::unique_ptr model, std::unique_ptr sink);

smuzaffar · 2024-02-12T19:39:30Z

@iarspider , can you please check if we can update cmssw code to fix https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37361/build-logs/PhysicsTools/NanoAOD/log.html build errors?

smuzaffar · 2024-02-12T22:51:00Z

ok, hopefully cms-sw/cmssw#43949 should fix the build errors

smuzaffar · 2024-02-12T22:51:14Z

test parameters:

pull_request = [ROOT6] RNTuple API change: RNTupleWriter is private cmssw#43949, Fix wildcard imports from ROOT (they are forbidden now) cmssw#43974, Drop PROOF tests (as discussed in #43975) cmssw#43996
enable = nano

smuzaffar · 2024-02-12T23:02:11Z

please test for CMSSW_14_1_ROOT6_X

smuzaffar · 2024-02-13T07:23:51Z

please test for CMSSW_14_1_ROOT6_X

cmsbuild · 2024-02-13T18:55:38Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37399/summary.html
COMMIT: 2e67a11
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-12-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8999/37399/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 4 errors in the following unit tests:

---> test test_TreeAndTkMapProducer had ERRORS
---> test TestRunnerFWCoreTFWLiteSelector had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
and more ...

Comparison Summary

Summary:

You potentially removed 29 lines from the logs
Reco comparison results: 941 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248554
DQMHistoTests: Total failures: 6623
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3241909
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-02-14T13:49:46Z

please test for CMSSW_14_1_ROOT6_X

smuzaffar · 2024-02-14T13:51:20Z

@iarspider , can you please look in to these failing unit tests. Looks like they are all related to the root master change

smuzaffar · 2024-02-14T14:04:31Z

looks like we need cleanup of https://github.com/search?q=repo%3Acms-sw%2Fcmssw+%22from+ROOT+import+*%22&type=code&p=1

cmsbuild · 2024-02-15T00:36:48Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37457/summary.html
COMMIT: 2e67a11
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-13-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8999/37457/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37457/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37457/git-merge-result

Unit Tests

I found 4 errors in the following unit tests:

---> test test_TreeAndTkMapProducer had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
---> test materialBudgetHGCalPlots had ERRORS
and more ...

Comparison Summary

Summary:

You potentially removed 9 lines from the logs
Reco comparison results: 4849 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248554
DQMHistoTests: Total failures: 13274
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3235258
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: found differences in 3 / 46 workflows

smuzaffar · 2024-02-15T10:36:38Z

please test for CMSSW_14_1_ROOT6_X

TPROOF unit test will fail but lets tests the reset of the changes (from ROOT import *)

cmsbuild · 2024-02-15T20:13:13Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37482/summary.html
COMMIT: 2e67a11
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-14-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8999/37482/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw grpcio: Changes backported from TF 2.15 branch #9015

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37482/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37482/git-merge-result

Unit Tests

I found 4 errors in the following unit tests:

---> test test_TreeAndTkMapProducer had ERRORS
---> test TestRunnerFWCoreTFWLiteSelector had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
and more ...

Comparison Summary

Summary:

You potentially removed 109 lines from the logs
Reco comparison results: 956 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248554
DQMHistoTests: Total failures: 7651
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3240881
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

iarspider · 2024-02-16T13:34:21Z

please test for CMSSW_14_1_ROOT6_X

iarspider · 2024-02-16T13:44:51Z

please abort

iarspider · 2024-02-16T13:48:12Z

please test for CMSSW_14_1_ROOT6_X

cmsbuild · 2024-02-17T04:53:25Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37525/summary.html
COMMIT: 2e67a11
CMSSW: CMSSW_14_1_ROOT6_X_2024-02-15-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8999/37525/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37525/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8df347/37525/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test test_TreeAndTkMapProducer had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
---> test materialBudgetHGCalPlots had ERRORS

Comparison Summary

Summary:

You potentially removed 97 lines from the logs
Reco comparison results: 952 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248554
DQMHistoTests: Total failures: 7649
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3240883
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-02-18T16:09:04Z

lets get this in root6 IBs . PR to fix the unit tests for from ROOT import * fix can be merged later

Updated root to tip of branch master

2e67a11

cmsbuild added externals-pending pending-signatures tests-started orp-pending labels Feb 12, 2024

smuzaffar mentioned this pull request Feb 12, 2024

[ROOT6] Updated root to tip of branch master #8995

Closed

cmsbuild added tests-rejected and removed tests-started labels Feb 12, 2024

cmsbuild added requires-external tests-started and removed tests-rejected labels Feb 12, 2024

cmsbuild added tests-rejected and removed tests-started labels Feb 12, 2024

cms-sw deleted a comment from cmsbuild Feb 12, 2024

smuzaffar mentioned this pull request Feb 13, 2024

[ROOT6] RNTuple API change: RNTupleWriter is private cms-sw/cmssw#43949

Merged

cmsbuild added tests-pending and removed tests-rejected labels Feb 16, 2024

cmsbuild added tests-rejected and removed tests-pending labels Feb 16, 2024

smuzaffar merged commit b371bcd into cms-sw:IB/CMSSW_14_1_X/rootmaster Feb 18, 2024

iarspider deleted the root-update-master-20240212 branch February 19, 2024 09:52

makortel mentioned this pull request Feb 19, 2024

[ROOT6_X] SIGSEGV in Validation/Geometry/materialBudget*Plots tests in G4PhysicalVolumeStore::Clean() cms-sw/cmssw#44009

Closed

iarspider mentioned this pull request Feb 19, 2024

Do we use PROOF? cms-sw/cmssw#43975

Closed

cmsbuild mentioned this pull request Feb 19, 2024

Updated root to tip of branch master #9025

Closed

smuzaffar mentioned this pull request Mar 11, 2024

Updated root to tip of branch master #9056

Merged

cmsbuild mentioned this pull request Apr 23, 2024

[ROOT6] Updated root to tip of branch master #9151

Merged

This was referenced Aug 11, 2025

[ROOT6] Root update master 20250811 #10005

Merged

meta: Allow global disabling of AutoParsing during TClass::GetClass cms-sw/root#222

Open

cmsbuild mentioned this pull request Oct 7, 2025

[ROOT6] Updated root to tip of branch master #10110

Merged

cmsbuild mentioned this pull request Nov 6, 2025

[ROOT6] Updated root to tip of branch master and used newer 6.39.1 version #10176

Closed

Conversation

iarspider commented Feb 12, 2024

Uh oh!

iarspider commented Feb 12, 2024

Uh oh!

cmsbuild commented Feb 12, 2024

Uh oh!

cmsbuild commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dr15Jones commented Feb 12, 2024

Uh oh!

cmsbuild commented Feb 12, 2024

Build

Uh oh!

smuzaffar commented Feb 12, 2024

Uh oh!

smuzaffar commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented Feb 12, 2024 • edited by iarspider Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented Feb 12, 2024

Uh oh!

smuzaffar commented Feb 13, 2024

Uh oh!

cmsbuild commented Feb 13, 2024

Unit Tests

Comparison Summary

Uh oh!

smuzaffar commented Feb 14, 2024

Uh oh!

smuzaffar commented Feb 14, 2024

Uh oh!

smuzaffar commented Feb 14, 2024

Uh oh!

cmsbuild commented Feb 15, 2024

Unit Tests

Comparison Summary

Uh oh!

smuzaffar commented Feb 15, 2024

Uh oh!

cmsbuild commented Feb 15, 2024

Unit Tests

Comparison Summary

Uh oh!

iarspider commented Feb 16, 2024

Uh oh!

iarspider commented Feb 16, 2024

Uh oh!

iarspider commented Feb 16, 2024

Uh oh!

cmsbuild commented Feb 17, 2024

Unit Tests

Comparison Summary

Uh oh!

smuzaffar commented Feb 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented Feb 12, 2024 •

edited

Loading

smuzaffar commented Feb 12, 2024 •

edited

Loading

smuzaffar commented Feb 12, 2024 •

edited by iarspider

Loading